Repository navigation
Add Windows ARM64 CI support - #1589
Li Jiang (thinkall) merged 14 commits into
Conversation
|
@microsoft-github-policy-service agree company="MulticoreWare" |
Li Jiang (thinkall)
left a comment
There was a problem hiding this comment.
Reviewed the ARM64 changes after updating the branch. The test dependency change also changes existing x64 environments and introduces the blocking incompatibility noted inline. Please scope the NumPy relaxation to Windows ARM64 while retaining compatible constraints for the existing matrix. The newly approved CI is still running.
Nithin Aashik PS (nithin-aashik-mcw)
left a comment
There was a problem hiding this comment.
Could you please take another look?
There was a problem hiding this comment.
🟡 Changes recommended
Unsupported-dependency handling can produce undefined names, and the cryptography pin unintentionally affects existing platforms.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Windows ARM64 CI coverage and adapts optional dependencies and tests for unavailable ARM64 packages.
Changes:
- Adds Windows ARM64 for Python 3.11–3.13.
- Applies platform-specific dependency markers.
- Skips tests requiring unsupported packages.
File summaries
| File | Description |
|---|---|
.github/workflows/python-package.yml |
Adds Windows ARM64 jobs. |
pyproject.toml |
Adjusts ARM64 test dependencies. |
test/test_gpu.py |
Skips unsupported Hugging Face testing. |
test/nlp/test_autohf.py |
Skips ARM64 dataset test. |
test/nlp/test_autohf_regression.py |
Skips ARM64 regression test. |
test/nlp/test_autohf_custom_metric.py |
Guards dataset usage. |
test/nlp/test_autohf_classificationhead.py |
Skips module on ARM64. |
test/automl/test_warmstart.py |
Skips MinIO-dependent test. |
test/automl/test_split.py |
Skips unavailable dependency cases. |
test/automl/test_score.py |
Skips CatBoost regression test. |
test/automl/test_regression.py |
Skips ARM64 CatBoost cases. |
test/automl/test_multiclass.py |
Skips CatBoost-dependent tests. |
test/automl/test_model.py |
Skips CatBoost preparation test. |
test/automl/test_custom_hp.py |
Skips unsupported NLP test. |
test/automl/test_classification.py |
Skips ARM64 CatBoost cases. |
test/autogen/oai/test_completion.py |
Guards the datasets import. |
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
Matrix typing, dependency markers, and remaining unguarded tests can still break CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 4
- Review effort level: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The AutoGen test changes introduce Ruff E402 and F401 failures that block pre-commit validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 17/17 changed files
- Comments generated: 2
- Review effort level: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The platform matrix, dependency markers, and targeted skips consistently support Windows ARM64 without altering existing x64 CI behavior.
Review details
- Files reviewed: 17/17 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Why are these changes needed?
windows-11-armto the GitHub Actions matrix and updated platform-specific dependencies.Checks