镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Add Windows ARM64 CI support - #1589

Merged
Li Jiang (thinkall) merged 14 commits into
microsoft:mainfrom
nithin-aashik-mcw:feature/win-arm64-support
Sep 8, 2026
Merged

Li Jiang (thinkall) merged 14 commits into
microsoft:mainfrom
nithin-aashik-mcw:feature/win-arm64-support

Conversation

@nithin-aashik-mcw

Copy link
Copy Markdown
Contributor

Why are these changes needed?

  • This PR adds support for running FLAML CI builds and tests on Windows ARM64.
  • Added windows-11-arm to the GitHub Actions matrix and updated platform-specific dependencies.
  • Added necessary test skips and dependency changes for packages without Windows ARM64 wheels.
  • Updated the test configuration to ensure the existing Windows and Linux CI behavior remains unchanged.

Checks

@nithin-aashik-mcw

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="MulticoreWare"

@thinkall Li Jiang (thinkall) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the ARM64 changes after updating the branch. The test dependency change also changes existing x64 environments and introduces the blocking incompatibility noted inline. Please scope the NumPy relaxation to Windows ARM64 while retaining compatible constraints for the existing matrix. The newly approved CI is still running.

Comment thread pyproject.toml Resolved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take another look?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unsupported-dependency handling can produce undefined names, and the cryptography pin unintentionally affects existing platforms.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds Windows ARM64 CI coverage and adapts optional dependencies and tests for unavailable ARM64 packages.

Changes:

  • Adds Windows ARM64 for Python 3.11–3.13.
  • Applies platform-specific dependency markers.
  • Skips tests requiring unsupported packages.
File summaries
File Description
.github/workflows/python-package.yml Adds Windows ARM64 jobs.
pyproject.toml Adjusts ARM64 test dependencies.
test/test_gpu.py Skips unsupported Hugging Face testing.
test/nlp/test_autohf.py Skips ARM64 dataset test.
test/nlp/test_autohf_regression.py Skips ARM64 regression test.
test/nlp/test_autohf_custom_metric.py Guards dataset usage.
test/nlp/test_autohf_classificationhead.py Skips module on ARM64.
test/automl/test_warmstart.py Skips MinIO-dependent test.
test/automl/test_split.py Skips unavailable dependency cases.
test/automl/test_score.py Skips CatBoost regression test.
test/automl/test_regression.py Skips ARM64 CatBoost cases.
test/automl/test_multiclass.py Skips CatBoost-dependent tests.
test/automl/test_model.py Skips CatBoost preparation test.
test/automl/test_custom_hp.py Skips unsupported NLP test.
test/automl/test_classification.py Skips ARM64 CatBoost cases.
test/autogen/oai/test_completion.py Guards the datasets import.
Review details
  • Files reviewed: 16/16 changed files
  • Comments generated: 3
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml Resolved
Comment thread test/autogen/oai/test_completion.py Resolved
Comment thread test/test_gpu.py Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Matrix typing, dependency markers, and remaining unguarded tests can still break CI.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 16/16 changed files
  • Comments generated: 4
  • Review effort level: Balanced

Comment thread .github/workflows/python-package.yml Resolved
Comment thread pyproject.toml Resolved
Comment thread test/autogen/oai/test_completion.py Resolved
Comment thread pyproject.toml Resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The AutoGen test changes introduce Ruff E402 and F401 failures that block pre-commit validation.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 17/17 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread test/autogen/oai/test_completion.py Resolved
Comment thread test/autogen/oai/test_completion.py Resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The platform matrix, dependency markers, and targeted skips consistently support Windows ARM64 without altering existing x64 CI behavior.

Review details
  • Files reviewed: 17/17 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@thinkall
Li Jiang (thinkall) added this pull request to the merge queue Sep 8, 2026
Merged via the queue into microsoft:main with commit d687a4d Sep 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants