镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix walkTokens not called on async marked call - #2060

Merged
UziTech merged 1 commit into
markedjs:masterfrom
UziTech:async-walk-tokens
May 21, 2021
Merged

UziTech merged 1 commit into
markedjs:masterfrom
UziTech:async-walk-tokens

Conversation

@UziTech

@UziTech UziTech commented May 19, 2021

Copy link
Copy Markdown
Member

Marked version: master

Description

walkTokens option was is not called when calling marked with a callback function.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel

vercel Bot commented May 19, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/Ez75JrN1MQM4aQUpgRKbQomMw4Mn
✅ Preview: https://markedjs-git-fork-uzitech-async-walk-tokens-markedjs.vercel.app

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@styfle

styfle commented May 21, 2021

Copy link
Copy Markdown
Member

@UziTech Is the commit message missing a semicolon? fix walkTokens => fix: walkTokens?

@UziTech

UziTech commented May 21, 2021

Copy link
Copy Markdown
Member Author

Ya it's only after squashing that we really need to follow the commit message rules.

@UziTech
UziTech merged commit 1d97308 into markedjs:master May 21, 2021
github-actions Bot pushed a commit that referenced this pull request May 21, 2021
## [2.0.5](v2.0.4...v2.0.5) (2021-05-21)

### Bug Fixes

* call walkTokens when calling marked with a callback([#2060](#2060)) ([1d97308](1d97308))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@UziTech
UziTech deleted the async-walk-tokens branch September 20, 2021 19:40
Logiclayer1111 pushed a commit to Logiclayer1111/marked that referenced this pull request Apr 20, 2026
## [2.0.5](markedjs/marked@v2.0.4...v2.0.5) (2021-05-21)

### Bug Fixes

* call walkTokens when calling marked with a callback([#2060](markedjs/marked#2060)) ([0e34760](markedjs/marked@0e34760))

This branch was successfully deployed

1 active deployment
Preview — 3034763c Deployed May 19, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants