镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: fix atx heading and make regex safe - #1853

Merged
UziTech merged 1 commit into
markedjs:masterfrom
UziTech:heading-safe
Dec 10, 2020
Merged

UziTech merged 1 commit into
markedjs:masterfrom
UziTech:heading-safe

Conversation

@UziTech

@UziTech UziTech commented Nov 27, 2020 •

Copy link
Copy Markdown
Member

Marked version: v1.2.5

Description

Make heading regex safe from redos and pass all atx heading spec tests.

fixes CommonMark spec test 49

possible breaking change: When using the block.heading rule the text provided in capture group 2 will not be trimmed of whitespace.

Since this is only a breaking change to the capture groups this doesn't require a major release but the previous statement should be copied to the release notes.

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

@vercel

vercel Bot commented Nov 27, 2020 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/ou05g5uok
✅ Preview: https://markedjs-git-heading-safe.markedjs.vercel.app

@UziTech
UziTech merged commit 70ee29c into markedjs:master Dec 10, 2020
@UziTech
UziTech deleted the heading-safe branch December 10, 2020 16:29
github-actions Bot pushed a commit that referenced this pull request Dec 10, 2020
## [1.2.6](v1.2.5...v1.2.6) (2020-12-10)

### Bug Fixes

* fix atx heading and make regex safe ([#1853](#1853)) ([70ee29c](70ee29c))
* fix link with angle brackets around href ([#1851](#1851)) ([656c3e4](656c3e4))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — 32c600e6 Deployed Nov 27, 2020 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants