镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix indented tables to follow gfm spec - #1748

Merged
styfle merged 1 commit into
markedjs:masterfrom
UziTech:indented-tables
Aug 13, 2020
Merged

styfle merged 1 commit into
markedjs:masterfrom
UziTech:indented-tables

Conversation

@UziTech

@UziTech UziTech commented Aug 12, 2020 •

Copy link
Copy Markdown
Member

Marked version: 1.1.1

Markdown flavor: GitHub Flavored Markdown

Description

fixes indented table rows to act like code blocks instead of table rows.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel

vercel Bot commented Aug 12, 2020 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/cvvaomc13
✅ Preview: https://markedjs-git-fork-uzitech-indented-tables.markedjs.vercel.app

@UziTech UziTech changed the title fix indented tables to act like gfm fix indented tables to follow gfm spec Aug 12, 2020

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the limit of 3 in the gfm spec?

Where do you see that?

@UziTech

UziTech commented Aug 13, 2020

Copy link
Copy Markdown
Member Author

If it is indented 4 spaces it is considered a code block. Which takes precedence over a table

@UziTech

UziTech commented Aug 13, 2020

Copy link
Copy Markdown
Member Author

Here is how github renders the test:

| abc | def |
            | --- | --- |
            | bar | foo |
            | baz | boo |

| abc | def |
| --- | --- |
| bar | foo |
| baz | boo |

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle
styfle merged commit 1d6afc1 into markedjs:master Aug 13, 2020
@UziTech
UziTech deleted the indented-tables branch August 31, 2020 21:14
@UziTech UziTech mentioned this pull request Sep 27, 2020
11 of 12 tasks
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — 2e99532b Deployed Aug 12, 2020 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing of whitespace prefixed tables broken after upgrade (0.7.0 => 1.1.1)

2 participants