镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix underscore emphasis then comma - #1660

Merged
UziTech merged 1 commit into
markedjs:masterfrom
UziTech:fix-em-comma
May 4, 2020
Merged

UziTech merged 1 commit into
markedjs:masterfrom
UziTech:fix-em-comma

Conversation

@UziTech

@UziTech UziTech commented May 2, 2020 •

Copy link
Copy Markdown
Member

Marked version: 1.0.0

Description

Fix regression when comma is after underscore emphasis

CommonMark Demo
Marked Demo, version 1.0.0 doesn’t work
Marked Demo, version 0.8.2 works

Fixes #1659

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel

vercel Bot commented May 2, 2020 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/ju4wzqb8l
✅ Preview: https://markedjs-git-fork-uzitech-fix-em-comma.markedjs.now.sh

@UziTech
UziTech merged commit a220ce9 into markedjs:master May 4, 2020
@UziTech
UziTech deleted the fix-em-comma branch May 4, 2020 15:45
@UziTech UziTech mentioned this pull request May 16, 2020
10 of 12 tasks

This branch was successfully deployed

1 active deployment
Preview — 61bc4ba7 Deployed May 2, 2020 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Underscores don’t turn into emphasis on 1.0.0

3 participants