镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix GFM Example 116 - #1600

Merged
styfle merged 1 commit into
markedjs:masterfrom
calculuschild:Fix-Example-116
Feb 11, 2020
Merged

styfle merged 1 commit into
markedjs:masterfrom
calculuschild:Fix-Example-116

Conversation

@calculuschild

@calculuschild calculuschild commented Feb 10, 2020 •

Copy link
Copy Markdown
Contributor

Marked version: 8.0

Markdown flavor: CommonMark & GitHub Flavored Markdown

Description

Also adds tests for detection of these fences if they should or not break paragraphs.

Implementing code as discussed in #1598 (comment)

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Only code fences made from backticks cannot have other backticks in the same line. Fences with tildes can have both tildes and backticks. This allows the tilde case to work correctly.

Also test for detection of these fences as they break or do not break paragraphs.
@vercel

vercel Bot commented Feb 10, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@UziTech UziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@calculuschild

Copy link
Copy Markdown
Contributor Author

Cool. Does anything else need to happen to merge this?

calculuschild added a commit to calculuschild/marked that referenced this pull request Feb 11, 2020
Fences after tables fixed in line with PR markedjs#1600.
@vercel
vercel Bot requested a deployment to Preview February 11, 2020 18:06 Abandoned
@vercel

vercel Bot commented Feb 11, 2020

Copy link
Copy Markdown

Deployment failed with the following error:

Configuring `regions` is not necessary for Static Files. Deploying Serverless Functions to multiple regions is restricted to paid plans. Upgrade here: https://zeit.co/teams/markedjs/settings/billing.

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@styfle
styfle merged commit 1f96816 into markedjs:master Feb 11, 2020
@UziTech UziTech mentioned this pull request Mar 6, 2020
11 of 12 tasks
tn0ms pushed a commit to warashibe/marked that referenced this pull request May 27, 2026
tn0ms pushed a commit to warashibe/marked that referenced this pull request May 27, 2026
Fences after tables fixed in line with PR markedjs#1600.

This branch had an error being deployed

1 abandoned deployment
Preview — 63454d24 Deployed Feb 11, 2020 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants