Repository navigation
Conversation
Member
|
thanks Wes! I've gone one further and added a commit that will ensure this is never* something we need to bother with again. Please take a look when you have a chance 🙏 * famous last words also, taking a look at the CI failure github is complaining about an obsolete action edit: alright just bumping version wasn't enough... looking at what changes we need to make |
Member
Author
|
Even better! The upload artifact stuff can be fixed out of band with this I think. My guess is that we need to make some similar changes to the CI (like turn off fast fail) that we have done in the other repos. |
Member
|
@wesleytodd fixed! |
ctcpip
force-pushed
the
gen-cert
branch
7 times, most recently
from
January 23, 2025 18:33
0a9f581 to
fe51d42
Compare
ctcpip
approved these changes
Jan 23, 2025
Member
|
reports making it to coveralls:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a PR to show what I meant in my comment in this thread @ctcpip #1003 (comment)
I was just thinking we could codify the whole thing so we don't need to debate what to do next time this happens.