镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Lazily check for foreign exes which may not be necessary for the curr… - #1257

Merged
nedtwigg merged 6 commits into
diffplug:mainfrom
bh-tt:main
Jul 27, 2022
Merged

nedtwigg merged 6 commits into
diffplug:mainfrom
bh-tt:main

Conversation

@bh-tt

@bh-tt bh-tt commented Jul 11, 2022 •

Copy link
Copy Markdown
Contributor

Run ForeignExe#confirmVersionAndGetAbsolutePath only once it is necessary.

Discussed in #673, I decided to make the 2 State implementations lazy with resolving the arguments.

@nedtwigg nedtwigg left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks! Needs some minor tweaks, but I like the approach.

Also, run spotlessApply so that CI passes :)

Comment thread CHANGES.md Resolved
@bh-tt

bh-tt commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

I processed your comments. Running ./gradlew spotlessApply from the project root changed no files, I'll assume that means the format is fine?

@bh-tt

bh-tt commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

Not even ./gradlew :lib:spotlessApply changes any files. I'm developing in a minimal container (only java, gradle and git installed), could that have something to do with it?

@nedtwigg

Copy link
Copy Markdown
Member

Sorry for the slow merge. I'll get this released by tomorrow. The spotlessApply issue you were bumping into is #1238

@nedtwigg
nedtwigg enabled auto-merge July 26, 2022 23:20
@nedtwigg
nedtwigg merged commit d78b6e3 into diffplug:main Jul 27, 2022
@nedtwigg

Copy link
Copy Markdown
Member

Sorry for the slow turnaround - finally released in plugin-gradle 6.9.0 and plugin-maven 2.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants