镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

migrate to c8 - #996

Merged
JLHwung merged 7 commits into
mainfrom
migrate-to-c8
Jul 18, 2023
Merged

JLHwung merged 7 commits into
mainfrom
migrate-to-c8

Conversation

@JLHwung

@JLHwung JLHwung commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes: migrate to c8
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information: Migrate to c8, leveraging the v8 builtin coverage tools.

@nicolo-ribaudo

Copy link
Copy Markdown
Member

Can we setup a CI check that shows the current coverage, with codecov or something similar?

@JLHwung

JLHwung commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

Here is the current coverage report: https://app.codecov.io/gh/babel/babel-loader

Can you install the codecov GitHub application to this repo? So the coverage should show up in checks.

@nicolo-ribaudo

Copy link
Copy Markdown
Member

I see it as already enabled 🤔 I'll try to understand why it's not working

image image

@nicolo-ribaudo

Copy link
Copy Markdown
Member

Oh, it also stopped reporting the coverage in the babel/babel repo since July 5th

@JLHwung

JLHwung commented Jul 7, 2023 •

Copy link
Copy Markdown
Contributor Author

The coverage report now looks good to me: https://app.codecov.io/github/babel/babel-loader/commit/3ed721a5c2c0af04dbac02d3f40ce20adcba3ee5/tree/src

it also stopped reporting the coverage in the babel/babel repo since July 5th

I have no idea why the codecov check is missing. Maybe the issue is on their sides.

@JLHwung
JLHwung merged commit df36cba into main Jul 18, 2023
@nicolo-ribaudo
nicolo-ribaudo deleted the migrate-to-c8 branch July 18, 2023 14:23
@nicolo-ribaudo

Copy link
Copy Markdown
Member

Codecov is back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants