镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix Liberica Java 25 release resolution - #1313

Merged
brunoborges merged 3 commits into
mainfrom
brunoborges-fix-liberica-java-25-resolution
Nov 4, 2026
Merged

brunoborges merged 3 commits into
mainfrom
brunoborges-fix-liberica-java-25-resolution

Conversation

@brunoborges

Copy link
Copy Markdown
Contributor

Description:
Preserve multi-component Liberica patch versions from the BellSoft API so a java-version: 25 request selects the latest 25.0.5.0.3+5 release rather than 25.0.5+11. Adds coverage for newest and exact patch resolution.

Validation: npm test -- --runTestsByPath __tests__/distributors/liberica-installer.test.ts --coverage=false (83 passed); npm test (1,594 passed); npm run lint, npm run format-check, npm run build, and git diff --check passed. The combined npm run check command was not run.

Related issue:
Fixes: #1306

Check list:

  • Ran npm run check locally (format, lint, build, test) and all checks pass.
  • Documentation changes are not required.
  • Tests were added or updated to cover the changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@brunoborges
brunoborges requested a review from a team as a code owner November 4, 2026 21:13
Copilot AI balanced review requested due to automatic review settings November 4, 2026 21:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The release comparator can select an older release when patch lengths differ because it compares build numbers against patch components, and the same critical defect exists in the bundled output.

1 open issue
What changed in this PR

This PR addresses #1306 by preserving multi-component Liberica patch versions so Java 25 requests can resolve to 25.0.5.0.3+5 instead of 25.0.5+11.

Changes:

  • Extends version normalization, exact patch matching, and release ordering to handle multiple patch components.
  • Adds tests for latest-release selection, exact patch requests, and version conversion.
  • Updates the generated setup bundle with the source changes.
File Description
src/​distributions/​liberica/​installer.ts Preserves and matches multi-component patches; adjusts ordering.
dist/​setup/​63.index.js Includes the updated Liberica logic in the runtime bundle.
__tests__/​distributors/​liberica-installer.test.ts Adds coverage for multi-component Liberica releases.

Review effort: Balanced

Comment thread src/distributions/liberica/installer.ts Resolved
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@brunoborges
brunoborges merged commit ef0b922 into main Nov 4, 2026
94 checks passed
@brunoborges
brunoborges deleted the brunoborges-fix-liberica-java-25-resolution branch November 4, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Liberica: java-version 25 resolves to 25.0.5+11 instead of the latest 25.0.5.0.3+5

2 participants