镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Support exact Corretto release versions - #1310

Merged
brunoborges merged 4 commits into
actions:mainfrom
electrum:user/electrum/corretto-exact-versions
Nov 4, 2026
Merged

brunoborges merged 4 commits into
actions:mainfrom
electrum:user/electrum/corretto-exact-versions

Conversation

@electrum

@electrum electrum commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Corretto workflows currently cannot pin a full release through java-version or java-version-file, forcing users to accept moving major releases or install archives themselves. Support full release numbers such as 25.0.5.0.10 using versioned archive URLs and published SHA-256 checksums, while preserving existing major/latest selection and tool-cache reuse.

Full Corretto release numbers in version files now select that exact release instead of the latest matching major. Older pins without a published SHA-256 must be updated; partial version-file values retain their existing major-version behavior.

Related issues: #953, #615.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 21:29
@electrum
electrum requested a review from a team as a code owner November 2, 2026 21:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the exact Amazon Corretto release-selection changes.

No open issues 🎉

What changed in this PR

Adds exact Amazon Corretto release selection to setup-java, addressing #953 while preserving major-version and latest behavior.

Changes:

  • Resolves full release numbers to versioned archives and retrieves archive-specific SHA-256 checksums from Amazon’s GitHub release notes.
  • Handles zero-padded Java 8 versions and adds tests for platform-specific URLs and rejection cases.
  • Documents exact-version support and updates the bundled action code.
File Description
src/​distributions/​corretto/​installer.ts Adds exact-release resolution, version normalization, and checksum lookup.
docs/​advanced-usage.md Documents full Corretto release numbers and checksum sourcing.
dist/​setup/​126.index.js Includes the installer changes in the runtime bundle.
__tests__/​distributors/​corretto-installer.test.ts Tests exact versions, archive URLs, missing checksums, and unsupported requests.

Review effort: Balanced

Corretto users cannot pin the release used by their local builds and
production. Accept full release numbers so a workflow keeps using its
chosen release after Amazon publishes a newer patch.
@electrum
electrum force-pushed the user/electrum/corretto-exact-versions branch from 5918b73 to 23e9965 Compare November 2, 2026 22:09
@brunoborges
brunoborges requested a max review from Copilot November 4, 2026 20:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved Corretto defects prevent catalog fallback after GitHub lookup failures and misinterpret documented Java 8 version-file values as nonexistent exact releases.

2 open issues

Review effort: Max

Comment thread src/distributions/corretto/installer.ts Resolved
Comment thread src/util.ts Resolved
brunoborges
brunoborges previously approved these changes Nov 4, 2026
brunoborges and others added 2 commits November 4, 2026 16:12
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@brunoborges
brunoborges merged commit 644a850 into actions:main Nov 4, 2026
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants