Repository navigation
More robust type checking - #578
Merged
Merged
Conversation
Contributor
I think Buffer is just an garbage wrapper and I'm not the only who think that I think all Buffer related stuff should go away since this is both a node and a web thingy and i wrote a best practises on how to write good cross platform stuff https://github.com/cross-js/cross-js#dont-use-buffer |
jonkoops
force-pushed
the
patch-1
branch
4 times, most recently
from
September 7, 2026 15:55
4ea5dba to
d52f95a
Compare
This was referenced Sep 8, 2026
If `input` comes from a different context, it might not be an instance of `window.Uint8Array` or `window.ArrayBuffer`. In particular, when reading a file in a Firefox extension using `OS.File.read`, a `Uint8Array` is returned that does not pass the `x instanceof Uint8Array` test. See https://stackoverflow.com/questions/15251879/how-to-check-if-a-variable-is-a-typed-array-in-javascript for more details.
Node tests use vm.runInNewContext to simulate sandboxed environments. Browser tests use an iframe realm for the same instanceof failure mode. Fixes Stuk#759 Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
approved these changes
Sep 8, 2026
jonkoops
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! I added cross-realm regression tests and confirmed this resolves the issue. LGTM
jonkoops
added a commit
that referenced
this pull request
Sep 8, 2026
Release preparation for 3.10.2 - Fix cross-realm binary type detection in `getTypeOf`. Fixes [#759](#759) (see [#578](#578)) - Add missing types for `JSZip.defaults`. Fixes [#690](#690) (see [#927](#927)) - Fix Blob support in Node.js 18 and up. Fixes [#941](#941) (see [#955](#955)) - Fix grunt build rebundling existing dist via browser field (see [#971](#971)) - Move all continuous integration to GitHub Actions (see [#942](#942)) - Upgrade Playwright to the latest version (see [#940](#940)) - Create FUNDING.yml Signed-off-by: Jon Koops <jonkoops@gmail.com>
renovate Bot
added a commit
to cigaleapp/cigale
that referenced
this pull request
Sep 24, 2026
##### [v3.10.2](https://github.com/Stuk/jszip/blob/HEAD/CHANGES.md#v3102-2026-09-09) - Fix cross-realm binary type detection in `getTypeOf`. Fixes [#759](Stuk/jszip#759) (see [#578](Stuk/jszip#578)) - Add missing types for `JSZip.defaults`. Fixes [#690](Stuk/jszip#690) (see [#927](Stuk/jszip#927)) - Fix Blob support in Node.js 18 and up. Fixes [#941](Stuk/jszip#941) (see [#955](Stuk/jszip#955))
renovate Bot
added a commit
to cigaleapp/cigale
that referenced
this pull request
Sep 27, 2026
##### [v3.10.2](https://github.com/Stuk/jszip/blob/HEAD/CHANGES.md#v3102-2026-09-09) - Fix cross-realm binary type detection in `getTypeOf`. Fixes [#759](Stuk/jszip#759) (see [#578](Stuk/jszip#578)) - Add missing types for `JSZip.defaults`. Fixes [#690](Stuk/jszip#690) (see [#927](Stuk/jszip#927)) - Fix Blob support in Node.js 18 and up. Fixes [#941](Stuk/jszip#941) (see [#955](Stuk/jszip#955))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
inputcomes from a different context, it might not be an instance ofwindow.Uint8Arrayorwindow.ArrayBuffer. In particular, when reading a file in a Firefox extension usingOS.File.read, aUint8Arrayis returned that does not pass thex instanceof Uint8Arraytest.See https://stackoverflow.com/questions/15251879/how-to-check-if-a-variable-is-a-typed-array-in-javascript for more details.
Fixes #759