Repository navigation
fix: firefox keypress event doesn't work with backspace, tab, etc, if preventDefault called - #7623
Merged
Merged
Conversation
… preventDefault called
Artem-Babich
force-pushed
the
fix-firefox-keypress
branch
from
April 11, 2023 09:01
8cdfa14 to
2722566
Compare
miherlosev
approved these changes
Apr 13, 2023
|
Release v2.5.1-rc.1 addresses this. |
1 similar comment
|
Release v2.5.1-rc.1 addresses this. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Old Firefox prevented backspace, tab, etc. keys via preventDefault(B254435).
Now this behavior is the same as in other modern browsers. So we don't need to prevent such key pressing.
Approach
Remove firefox check
References
#4115
Pre-Merge TODO