|
| 1 | +""" |
| 2 | +Coverage for negative and large-magnitude rowids in vec0 tables. |
| 3 | +
|
| 4 | +vec0 accepts any i64 rowid, and downstream applications assign |
| 5 | +deterministic negative rowids (e.g. rowid = -source_id). These tests |
| 6 | +exercise insert, point lookup, update, delete, KNN result reporting, |
| 7 | +metadata/auxiliary/partition columns, and the KNN `rowid IN (...)` |
| 8 | +filter with rowids that are negative and/or span more than 2^31. |
| 9 | +""" |
| 10 | + |
| 11 | +import sqlite3 |
| 12 | + |
| 13 | +import pytest |
| 14 | + |
| 15 | +INT64_MIN = -(2**63) |
| 16 | +INT64_MAX = 2**63 - 1 |
| 17 | + |
| 18 | + |
| 19 | +def test_insert_and_point_lookup(db): |
| 20 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[2])") |
| 21 | + rowids = [INT64_MIN, -4_000_000_000, -42, -1, 0, 1, 4_000_000_000, INT64_MAX] |
| 22 | + for i, rowid in enumerate(rowids): |
| 23 | + db.execute( |
| 24 | + "INSERT INTO v(rowid, embedding) VALUES (?, ?)", [rowid, f"[{i}, {i}]"] |
| 25 | + ) |
| 26 | + |
| 27 | + for i, rowid in enumerate(rowids): |
| 28 | + row = db.execute( |
| 29 | + "SELECT rowid, vec_to_json(embedding) AS e FROM v WHERE rowid = ?", |
| 30 | + [rowid], |
| 31 | + ).fetchone() |
| 32 | + assert row["rowid"] == rowid |
| 33 | + assert row["e"] == f"[{i}.000000,{i}.000000]" |
| 34 | + |
| 35 | + assert db.execute("SELECT count(*) FROM v").fetchone()[0] == len(rowids) |
| 36 | + |
| 37 | + |
| 38 | +def test_update(db): |
| 39 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[2])") |
| 40 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (-7, '[1, 1]')") |
| 41 | + db.execute("UPDATE v SET embedding = '[9, 9]' WHERE rowid = -7") |
| 42 | + row = db.execute( |
| 43 | + "SELECT vec_to_json(embedding) AS e FROM v WHERE rowid = -7" |
| 44 | + ).fetchone() |
| 45 | + assert row["e"] == "[9.000000,9.000000]" |
| 46 | + |
| 47 | + |
| 48 | +def test_delete(db): |
| 49 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[2])") |
| 50 | + for rowid in [-3, -2, -1, 1, 2]: |
| 51 | + db.execute( |
| 52 | + "INSERT INTO v(rowid, embedding) VALUES (?, ?)", |
| 53 | + [rowid, f"[{rowid}, {rowid}]"], |
| 54 | + ) |
| 55 | + db.execute("DELETE FROM v WHERE rowid = -2") |
| 56 | + remaining = [r[0] for r in db.execute("SELECT rowid FROM v ORDER BY rowid")] |
| 57 | + assert remaining == [-3, -1, 1, 2] |
| 58 | + assert db.execute("SELECT count(*) FROM v WHERE rowid = -2").fetchone()[0] == 0 |
| 59 | + # a deleted negative rowid can be re-inserted |
| 60 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (-2, '[5, 5]')") |
| 61 | + assert db.execute("SELECT count(*) FROM v WHERE rowid = -2").fetchone()[0] == 1 |
| 62 | + |
| 63 | + |
| 64 | +def test_duplicate_negative_rowid_rejected(db): |
| 65 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[2])") |
| 66 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (-7, '[1, 1]')") |
| 67 | + with pytest.raises(sqlite3.OperationalError, match="UNIQUE constraint failed"): |
| 68 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (-7, '[2, 2]')") |
| 69 | + |
| 70 | + |
| 71 | +def test_knn_reports_negative_rowids(db): |
| 72 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[2])") |
| 73 | + # rowid -i holds [i, i], so KNN order from origin is -1, -2, -3, ... |
| 74 | + for i in range(1, 11): |
| 75 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (?, ?)", [-i, f"[{i}, {i}]"]) |
| 76 | + rows = db.execute( |
| 77 | + "SELECT rowid, distance FROM v WHERE embedding MATCH '[0, 0]' AND k = 3 " |
| 78 | + "ORDER BY distance" |
| 79 | + ).fetchall() |
| 80 | + assert [r["rowid"] for r in rows] == [-1, -2, -3] |
| 81 | + |
| 82 | + |
| 83 | +def test_knn_negative_rowids_across_chunks(db): |
| 84 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[1], chunk_size=8)") |
| 85 | + for i in range(-25, 25): |
| 86 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (?, ?)", [i, f"[{i}]"]) |
| 87 | + db.execute("DELETE FROM v WHERE rowid IN (-25, -1, 0, 24)") |
| 88 | + rows = db.execute( |
| 89 | + "SELECT rowid FROM v WHERE embedding MATCH '[0]' AND k = 4 ORDER BY distance" |
| 90 | + ).fetchall() |
| 91 | + assert sorted(r["rowid"] for r in rows) == [-3, -2, 1, 2] |
| 92 | + |
| 93 | + |
| 94 | +def test_metadata_filter_with_negative_rowids(db): |
| 95 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[2], category TEXT)") |
| 96 | + for i in range(1, 11): |
| 97 | + category = "even" if i % 2 == 0 else "odd" |
| 98 | + db.execute( |
| 99 | + "INSERT INTO v(rowid, embedding, category) VALUES (?, ?, ?)", |
| 100 | + [-i, f"[{i}, {i}]", category], |
| 101 | + ) |
| 102 | + rows = db.execute( |
| 103 | + "SELECT rowid, category FROM v " |
| 104 | + "WHERE embedding MATCH '[0, 0]' AND k = 3 AND category = 'even' " |
| 105 | + "ORDER BY distance" |
| 106 | + ).fetchall() |
| 107 | + assert [r["rowid"] for r in rows] == [-2, -4, -6] |
| 108 | + assert all(r["category"] == "even" for r in rows) |
| 109 | + |
| 110 | + |
| 111 | +def test_auxiliary_and_partition_with_negative_rowids(db): |
| 112 | + db.execute( |
| 113 | + "CREATE VIRTUAL TABLE v USING vec0(" |
| 114 | + " user_id INTEGER partition key, embedding float[2], +contents TEXT" |
| 115 | + ")" |
| 116 | + ) |
| 117 | + for i in range(1, 7): |
| 118 | + db.execute( |
| 119 | + "INSERT INTO v(rowid, user_id, embedding, contents) VALUES (?, ?, ?, ?)", |
| 120 | + [-i, i % 2, f"[{i}, {i}]", f"item {i}"], |
| 121 | + ) |
| 122 | + rows = db.execute( |
| 123 | + "SELECT rowid, contents FROM v " |
| 124 | + "WHERE embedding MATCH '[0, 0]' AND k = 2 AND user_id = 0 " |
| 125 | + "ORDER BY distance" |
| 126 | + ).fetchall() |
| 127 | + assert [r["rowid"] for r in rows] == [-2, -4] |
| 128 | + assert [r["contents"] for r in rows] == ["item 2", "item 4"] |
| 129 | + |
| 130 | + |
| 131 | +def test_knn_rowid_in_negative(db): |
| 132 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[2])") |
| 133 | + for i in range(1, 11): |
| 134 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (?, ?)", [-i, f"[{i}, {i}]"]) |
| 135 | + rows = db.execute( |
| 136 | + "SELECT rowid FROM v WHERE embedding MATCH '[0, 0]' AND k = 10 " |
| 137 | + "AND rowid IN (-2, -5, -9) ORDER BY distance" |
| 138 | + ).fetchall() |
| 139 | + assert [r["rowid"] for r in rows] == [-2, -5, -9] |
| 140 | + |
| 141 | + |
| 142 | +def test_knn_rowid_in_span_exceeding_2_31(db): |
| 143 | + """Regression test: the qsort/bsearch comparator for `rowid IN (...)` |
| 144 | + returned the i64 rowid difference narrowed to int. The subtraction can |
| 145 | + overflow and the narrowing keeps only the low 32 bits, so unequal |
| 146 | + rowids could compare as equal or with the wrong sign (a difference of |
| 147 | + 2^31 wraps negative), giving qsort an inconsistent ordering and making |
| 148 | + bsearch silently drop matching rowids from KNN results.""" |
| 149 | + db.execute("CREATE VIRTUAL TABLE v USING vec0(embedding float[1])") |
| 150 | + rowids = [ |
| 151 | + -4_000_000_000, |
| 152 | + -(2**31) - 7, |
| 153 | + 0, |
| 154 | + 2**31, |
| 155 | + 2**32 + 5, |
| 156 | + 4_000_000_000, |
| 157 | + ] |
| 158 | + for i, rowid in enumerate(rowids): |
| 159 | + db.execute("INSERT INTO v(rowid, embedding) VALUES (?, ?)", [rowid, f"[{i}]"]) |
| 160 | + placeholders = ",".join("?" * len(rowids)) |
| 161 | + rows = db.execute( |
| 162 | + f"SELECT rowid FROM v WHERE embedding MATCH '[0]' AND k = {len(rowids)} " |
| 163 | + f"AND rowid IN ({placeholders}) ORDER BY distance", |
| 164 | + rowids, |
| 165 | + ).fetchall() |
| 166 | + assert sorted(r["rowid"] for r in rows) == sorted(rowids) |
0 commit comments