镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

feat: download only yarn.js from npm - #439

Merged
aduh95 merged 21 commits into
nodejs:mainfrom
zhyupe:fix/yarn-berry-hash
Apr 1, 2024
Merged

aduh95 merged 21 commits into
nodejs:mainfrom
zhyupe:fix/yarn-berry-hash

Conversation

@zhyupe

@zhyupe zhyupe commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Added bin property to NpmRegistrySpec. When installing yarn berry from custom registry, it'll only install the bin file and calculate hash of the bin file itself.

Fix #435

@aduh95

aduh95 commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Have you considered using filter option of tar.x?

Comment thread sources/corepackUtils.ts Resolved
Comment thread sources/corepackUtils.ts Resolved
Comment thread sources/corepackUtils.ts Resolved
zhyupe and others added 4 commits March 26, 2024 11:01
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Comment thread sources/corepackUtils.ts Resolved
Comment thread sources/corepackUtils.ts Resolved
Co-authored-by: Maël Nison <nison.mael@gmail.com>
Comment thread sources/corepackUtils.ts Resolved
Comment thread sources/corepackUtils.ts Resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Comment thread sources/corepackUtils.ts Resolved
Comment thread sources/corepackUtils.ts Resolved
@aduh95

aduh95 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

Other than tests, is there something else to be done before this can be marked as ready for reviews?

@zhyupe

zhyupe commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

Other than tests, is there something else to be done before this can be marked as ready for reviews?

No, I think. But I'm experiencing some networking problems and have little time resolving it. So may be it will be ready in 1-2 days.

@zhyupe
zhyupe marked this pull request as ready for review March 26, 2024 16:31
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Comment thread tests/main.test.ts Resolved
zhyupe and others added 3 commits March 28, 2024 00:06
@zhyupe

zhyupe commented Mar 29, 2024

Copy link
Copy Markdown
Contributor Author

@aduh95 Waiting for #445 being merged or the tests would fail

@aduh95
aduh95 merged commit 4672162 into nodejs:main Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hash validation failed for yarn when COREPACK_NPM_REGISTRY is set on one side

3 participants