Repository navigation
fix(github): optimize notification enrichment requests - #3583
Merged
Merged
Conversation
Restore the 100-notification merged enrichment batch and split it in half on GitHub resource-limit errors, down to batches of 25 before falling back to per-notification enrichment. Bound expensive enrichment connections to keep the larger batch within GitHub's resource budget: labels 25 with totalCount, issue fields 25, review threads 25, reviews 25, linked issues 10, and discussion comments/replies 5/5. Carry the true label count through the subject so the labels pill reports the total while rendering the fetched tokens. Update tests and GraphQL codegen for the new bounds.
|
Contributor
|
🎉 This pull request is included in Gitify v8.0.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merged enrichment batch was reduced to 25 after GitHub started rejecting 100-notification batches with
Resource limits for this query exceeded. That avoids the failure but quadruples enrichment requests per polling interval. The query had grown with recent metric fields such as reviews, review threads, issue fields, linked issues, and CI checks.Change
100 -> 50 -> 25split-and-retry only on GitHub's resource-limit error. Other errors keep the existing handling.totalCounttotalCountwhile rendering the fetched tokens.sincechanges.Trade-offs
Testing
pnpm test— 209 files, 2056 tests passedpnpm check— formatting, lint, and types passopenspec validate optimize-github-enrichment-requests --store gitify-specs --strict— validOpenSpec change:
optimize-github-enrichment-requests