Repository navigation
fix: enforce zoom limits on shortcuts and hide login scrollbar - #3569
Merged
Merged
Conversation
Electron's default menu handled Cmd/Ctrl +/-/0 with its own 0.5 zoom-level steps and ignored Gitify's 0-120% bounds. Intercept those shortcuts in the main process, forward them to the renderer, and reuse the app's 10% step and clamping. Also snap any other native zoom change back into range.
The fixed-height login screen can exceed the viewport once the interface is zoomed, which surfaced a vertical scrollbar over the centred composition. Keep the container scrollable but hide its scrollbar, and remove Primer's trailing paragraph margin so the forge tagline sits flush with the rest of the secondary content.
|
Contributor
|
🎉 This pull request is included in Gitify v8.0.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd/Ctrl++,-,0zoom accelerators and route them through Gitify's own zoom logic, so keyboard zoom uses the configured 10% step and respects the 0–120% bounds.Testing
pnpm checkpnpm test— 2015 tests passedpnpm test:visual:update— 166 tests passed; login baselines refreshedNotes
The Electron application menu still exposes its built-in Zoom In/Out items. Those continue to step natively, but the renderer sync now snaps them back to the supported range.