fix: propagate extension removal refusal to bundle uninstall

_ExtensionKindManager.remove() discarded ExtensionManager.remove()'s
bool result, so a tampered registry id or symlinked target that made
the security guard refuse to act still let remove_bundle() record the
component as uninstalled and drop the bundle's ownership metadata,
leaving the extension on disk. Raise BundlerError when remove()
returns False so the bundle removal fails instead of silently
succeeding.

Also add a regression test covering the previously-untested
regular-file preset target rejection in PresetManager.remove().

Author: chelsealong

src/specify_cli/bundles/primitives.py

@@ -313,11 +313,16 @@ def _do_install(self, component: ComponentRef, *, force: bool) -> None:
 
     def remove(self, component: ComponentRef) -> None:
         try:
-            self._manager.remove(component.id)
+            removed = self._manager.remove(component.id)
         except Exception as exc:  # noqa: BLE001
             raise BundlerError(
                 f"Failed to remove extension '{component.id}': {exc}"
             ) from exc
+        if not removed:
+            raise BundlerError(
+                f"Failed to remove extension '{component.id}': removal was "
+                "refused (unsafe registry id or symlinked target)."
+            )
 
 
 class _WorkflowKindManager:

tests/specify_cli/bundles/test_primitives.py

@@ -70,6 +70,31 @@ def test_default_installer_threads_allow_network(tmp_path: Path):
         installer.install(tmp_path, _component("workflows"))
 
 
+def test_extension_remove_propagates_refusal_as_bundler_error(tmp_path: Path):
+    """A tampered registry/symlinked target must fail the bundle removal, not
+    silently report success while leaving the extension installed on disk.
+
+    ``ExtensionManager.remove()`` returns ``False`` when it refuses to act on
+    an unsafe target; the bundle adapter must surface that refusal instead of
+    discarding it, or ``remove_bundle()`` would record the component as
+    uninstalled while it is still on disk.
+    """
+    manager = primitive_manager("extensions", tmp_path)
+    manager._manager.registry.add("test-ext", {"version": "1.0.0"})
+
+    ext_dir = tmp_path / ".specify" / "extensions" / "test-ext"
+    ext_dir.parent.mkdir(parents=True, exist_ok=True)
+    real_target = tmp_path / "real-target"
+    real_target.mkdir()
+    ext_dir.symlink_to(real_target, target_is_directory=True)
+
+    with pytest.raises(BundlerError, match="removal was refused"):
+        manager.remove(_component("extensions", "test-ext"))
+
+    assert ext_dir.is_symlink()
+    assert manager._manager.registry.is_installed("test-ext")
+
+
 @pytest.mark.parametrize("kind", ["presets", "extensions", "workflows", "steps"])
 def test_offline_refresh_explains_component_needs_network(tmp_path: Path, kind: str):
     installer = DefaultPrimitiveInstaller(allow_network=False)

tests/specify_cli/presets/test_manager.py

@@ -355,6 +355,22 @@ def test_remove_refuses_dangling_symlinked_preset_dir(self, project_dir):
         assert pack_dir.is_symlink()
         assert manager.registry.is_installed("test-pack")
 
+    def test_remove_refuses_regular_file_preset_dir(self, project_dir):
+        """A regular file at the preset path must fail explicitly, not crash
+        ``shutil.rmtree`` or leave the registry mutated."""
+        manager = PresetManager(project_dir)
+        manager.registry.add("test-pack", {"version": "1.0.0"})
+
+        pack_dir = project_dir / ".specify" / "presets" / "test-pack"
+        pack_dir.parent.mkdir(parents=True, exist_ok=True)
+        pack_dir.write_text("not a directory")
+
+        result = manager.remove("test-pack")
+
+        assert result is False
+        assert pack_dir.is_file()
+        assert manager.registry.is_installed("test-pack")
+
     def test_list_installed(self, project_dir, pack_dir):
         """Test listing installed packs."""
         manager = PresetManager(project_dir)