Repository navigation
feat(mosaic): rebuild styled Table on the Table primitive - #10421
Draft
alexcarpenter wants to merge 3 commits into
Draft
alexcarpenter wants to merge 3 commits into
alexcarpenter wants to merge 3 commits into
Conversation
Migrate the API keys table and drop its unused sort props.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ba25d67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #10414. Rebuilds the styled Mosaic
Tableon the headless Table primitive and moves its consumers over.Tablewraps the primitive's parts with Mosaic styles.Table.Rootnow owns selection, tree expansion, sort and keyboard navigation.Table.Bodyrenders fromitemswith a render function and arenderEmptyState.Table.Columntakeswidth,sortableandrowHeader, replacingHeaderCellandColumnGroup.SelectionColumn,SelectionCellandExpandButtonneed anaria-label, so the copy stays in the features.useDataTableanduseServerDataTableare removed, along with their swingset pages and the AGENTS.md reuse row.sort/onSortChangeprops on the API keys table are removed. No controller or model passed them; only the swingset fixture did.Behavior changes:
Row disabledand are nowaria-disabled.data-actionableinstead ofdata-interactive.Commits 1 and 2 don't typecheck on their own: the hooks still import old Table types until commit 3, and the members panel uses the old parts until commit 2. The branch head typechecks.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change